cypher: Add cypher output using neo4j driver #2877
Merged
+986
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockwotj
force-pushed
the
neo4j
branch
2 times, most recently
from
dc9abbd
to
f74971f
Compare
rockwotj
requested review from
Jeffail and
mihaitodor
and removed request for
Jeffail
|
I am going to add an integration test first. |
|
Added an integration test 🎉 |
Jeffail
reviewed
Sep 24, 2024
mihaitodor
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Thanks @rockwotj! I left a few small comments, but it should be good to go otherwise.
rockwotj
commented
Sep 24, 2024
|
|
||
| ### Fixed | ||
|
|
||
| - Fixed a bug with the `input_resource` field for the `kafka_migrator` output where new topics weren't created as expected. (@mihaitodor) | ||
| - Fixed a bug in the `kafka_migrator` input which could lead to extra duplicate messages during a consumer group rebalance. (@mihaitodor) | ||
| - `kafka_migrator`, `kafka_migrator_offsets` and `kafka_migrator_bundle` components renamed to `redpanda_migrator`, `redpanda_migrator_offsets` and `redpanda_migrator_bundle` (@mihaitodor) | ||
|
|
||
| ## 4.36.0 - 2024-09-11 |
There was a problem hiding this comment.
Will fix this in my couchbase PR 🤦
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #869