Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chart-testing github action is flakey or broken #1097

Closed
Tracked by #1095
chrisseto opened this issue Mar 19, 2024 · 2 comments · Fixed by #1100
Closed
Tracked by #1095

Chart-testing github action is flakey or broken #1097

chrisseto opened this issue Mar 19, 2024 · 2 comments · Fixed by #1100

Comments

@chrisseto
Copy link
Contributor

The fork of chart-testing that we're using appears to be breaking but only on certain build steps: https://github.com/redpanda-data/helm-charts/actions/runs/8347611627/job/22854783792?pr=1089
@chrisseto chrisseto mentioned this issue Mar 19, 2024
Closed
@chrisseto
Copy link
Contributor Author

Hmm, the plot thickens. For some reason #1089 successfully automerged but I can't trackdown a passing run of the actions in github's Actions tab. When you expand the details of the merge, it does indicate that there was a successful run however.

@chrisseto
Copy link
Contributor Author

AH. Got it. There's a collision of names now. Since there was gocode within the referenced PR it ran the non-Chart action which passed. Github saw that there was an action with the name "summary" and "lint" and decided that was good enough.

This further reinforces my desire to collapse down the workflow definitions to one pull_request action and then perform filtering on changes within the Job(s).

chrisseto added a commit that referenced this issue Mar 20, 2024
@chrisseto
Add chart-testing and chart-releaser to flake.nix
713824f 
This commit adds the necessary nix files to install `chart-releaser`,
which is not available in nixpkgs, and joejuilian's fork of
`chart-testing`.

Doing so paves the way towards replacing unnecessary github actions
(anything that could be replaced with nix and a single shell command)
with nix to cut down on the duplication of dependencies.

This work was motivated by the sudden flakiness of installing github
actions. See also #1097.
@chrisseto chrisseto mentioned this issue Mar 20, 2024
Closed
chrisseto added a commit that referenced this issue Mar 20, 2024
@chrisseto
replace chart-testing and helm github actions with nix
ee07806 
This commit removes all references to joejulian/chart-testing-action and
azure/setup-helm in favor of relying on nix to provide these packages.

There are a few side effects to this commit:
- All github actions are now run through `nix develop --impure --command
  bash`. This may interact strangely with the actions that install a
  dependency (ie kind) but would only result in running the version
  that's provided by nix.
- helm has been upgraded to `v3.14.2`

Fixes #1097.
@chrisseto chrisseto mentioned this issue Mar 20, 2024
Merged
chrisseto added a commit that referenced this issue Mar 20, 2024
@chrisseto
replace chart-testing and helm github actions with nix
b44e9ee 
This commit removes all references to joejulian/chart-testing-action and
azure/setup-helm in favor of relying on nix to provide these packages.

There are a few side effects to this commit:
- All github actions are now run through `nix develop --impure --command
  bash`. This may interact strangely with the actions that install a
  dependency (ie kind) but would only result in running the version
  that's provided by nix.
- helm has been upgraded to `v3.14.2`

Fixes #1097.
chrisseto added a commit that referenced this issue Mar 20, 2024
@chrisseto
Add chart-testing and chart-releaser to flake.nix
bf2d27a 
This commit adds the necessary nix files to install `chart-releaser`,
which is not available in nixpkgs, and joejuilian's fork of
`chart-testing`.

Doing so paves the way towards replacing unnecessary github actions
(anything that could be replaced with nix and a single shell command)
with nix to cut down on the duplication of dependencies.

This work was motivated by the sudden flakiness of installing github
actions. See also #1097.
chrisseto added a commit that referenced this issue Mar 20, 2024
@chrisseto
replace chart-testing and helm github actions with nix
1d31f7e 
This commit removes all references to joejulian/chart-testing-action and
azure/setup-helm in favor of relying on nix to provide these packages.

There are a few side effects to this commit:
- All github actions are now run through `nix develop --impure --command
  bash`. This may interact strangely with the actions that install a
  dependency (ie kind) but would only result in running the version
  that's provided by nix.
- helm has been upgraded to `v3.14.2`

Fixes #1097.
chrisseto added a commit that referenced this issue Mar 20, 2024
@chrisseto
replace chart-testing and helm github actions with nix
4f694c9 
This commit removes all references to joejulian/chart-testing-action and
azure/setup-helm in favor of relying on nix to provide these packages.

There are a few side effects to this commit:
- All github actions are now run through `nix develop --impure --command
  bash`. This may interact strangely with the actions that install a
  dependency (ie kind) but would only result in running the version
  that's provided by nix.
- helm has been upgraded to `v3.14.2`

Fixes #1097.
chrisseto added a commit that referenced this issue Mar 20, 2024
@chrisseto
Add chart-testing and chart-releaser to flake.nix
767ddaf 
This commit adds the necessary nix files to install `chart-releaser`,
which is not available in nixpkgs, and joejuilian's fork of
`chart-testing`.

Doing so paves the way towards replacing unnecessary github actions
(anything that could be replaced with nix and a single shell command)
with nix to cut down on the duplication of dependencies.

This work was motivated by the sudden flakiness of installing github
actions. See also #1097.
chrisseto added a commit that referenced this issue Mar 20, 2024
@chrisseto
replace chart-testing and helm github actions with nix
2cf7a99 
This commit removes all references to joejulian/chart-testing-action and
azure/setup-helm in favor of relying on nix to provide these packages.

There are a few side effects to this commit:
- All github actions are now run through `nix develop --impure --command
  bash`. This may interact strangely with the actions that install a
  dependency (ie kind) but would only result in running the version
  that's provided by nix.
- helm has been upgraded to `v3.14.2`

Fixes #1097.
chrisseto added a commit that referenced this issue Mar 20, 2024
@chrisseto
replace chart-testing and helm github actions with nix
9f05bb7 
This commit removes all references to joejulian/chart-testing-action and
azure/setup-helm in favor of relying on nix to provide these packages.

There are a few side effects to this commit:
- All github actions are now run through `nix develop --impure --command
  bash`. This may interact strangely with the actions that install a
  dependency (ie kind) but would only result in running the version
  that's provided by nix.
- helm has been upgraded to `v3.14.2`

Fixes #1097.
chrisseto added a commit that referenced this issue Mar 21, 2024
@chrisseto
Add chart-testing and chart-releaser to flake.nix
7f3f473 
This commit adds the necessary nix files to install `chart-releaser`,
which is not available in nixpkgs, and joejuilian's fork of
`chart-testing`.

Doing so paves the way towards replacing unnecessary github actions
(anything that could be replaced with nix and a single shell command)
with nix to cut down on the duplication of dependencies.

This work was motivated by the sudden flakiness of installing github
actions. See also #1097.
chrisseto added a commit that referenced this issue Mar 21, 2024
@chrisseto
replace chart-testing and helm github actions with nix
b49d3c8 
This commit removes all references to joejulian/chart-testing-action and
azure/setup-helm in favor of relying on nix to provide these packages.

There are a few side effects to this commit:
- All github actions are now run through `nix develop --impure --command
  bash`. This may interact strangely with the actions that install a
  dependency (ie kind) but would only result in running the version
  that's provided by nix.
- helm has been upgraded to `v3.14.2`

Fixes #1097.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

replace chart-testing and helm github actions with nix redpanda-data/helm-charts
1 participant
@chrisseto