redpanda: Convert services.nodeport.yaml to go code
#1168
Assignees
Comments
chrisseto
added a commit
that referenced
this issue
Apr 10, 2024
This commit converts the `service.nodeport.yaml` helm template to an equivalent go function. There are a few notable changes to the logic that should NOT result in any behavioral changes. 1. There used to be a for loop over all external listeners that checked for .Enabled and .Type on them. There was no .Type attribute on the external listeners therefore the entire chunk of logic was a no-op. 2. Each loop over an external listener would check the global values of .Values.External.Enabled. As the go function short circuits, this check is no longer required. Fixes #1168.
chrisseto
added a commit
that referenced
this issue
Apr 11, 2024
This commit converts the `service.nodeport.yaml` helm template to an equivalent go function. There are a few notable changes to the logic that should NOT result in any behavioral changes. 1. There used to be a for loop over all external listeners that checked for .Enabled and .Type on them. There was no .Type attribute on the external listeners therefore the entire chunk of logic was a no-op. 2. Each loop over an external listener would check the global values of .Values.External.Enabled. As the go function short circuits, this check is no longer required. Fixes #1168.
chrisseto
added a commit
that referenced
this issue
Apr 11, 2024
This commit converts the `service.nodeport.yaml` helm template to an equivalent go function. There are a few notable changes to the logic that should NOT result in any behavioral changes. 1. There used to be a for loop over all external listeners that checked for .Enabled and .Type on them. There was no .Type attribute on the external listeners therefore the entire chunk of logic was a no-op. 2. Each loop over an external listener would check the global values of .Values.External.Enabled. As the go function short circuits, this check is no longer required. Fixes #1168.
chrisseto
added a commit
that referenced
this issue
Apr 11, 2024
This commit converts the `service.nodeport.yaml` helm template to an equivalent go function. There are a few notable changes to the logic that should NOT result in any behavioral changes. 1. There used to be a for loop over all external listeners that checked for .Enabled and .Type on them. There was no .Type attribute on the external listeners therefore the entire chunk of logic was a no-op. 2. Each loop over an external listener would check the global values of .Values.External.Enabled. As the go function short circuits, this check is no longer required. Fixes #1168.
RafalKorepta
pushed a commit
that referenced
this issue
Apr 12, 2024
This commit converts the `service.nodeport.yaml` helm template to an equivalent go function. There are a few notable changes to the logic that should NOT result in any behavioral changes. 1. There used to be a for loop over all external listeners that checked for .Enabled and .Type on them. There was no .Type attribute on the external listeners therefore the entire chunk of logic was a no-op. 2. Each loop over an external listener would check the global values of .Values.External.Enabled. As the go function short circuits, this check is no longer required. Fixes #1168.
RafalKorepta
pushed a commit
that referenced
this issue
Apr 12, 2024
This commit converts the `service.nodeport.yaml` helm template to an equivalent go function. There are a few notable changes to the logic that should NOT result in any behavioral changes. 1. There used to be a for loop over all external listeners that checked for .Enabled and .Type on them. There was no .Type attribute on the external listeners therefore the entire chunk of logic was a no-op. 2. Each loop over an external listener would check the global values of .Values.External.Enabled. As the go function short circuits, this check is no longer required. Fixes #1168.
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: