Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redpanda: Convert service.loadbalancer.yaml to go code #1215

Closed
Tracked by #1092
chrisseto opened this issue Apr 18, 2024 · 0 comments · Fixed by #1347
Closed
Tracked by #1092

redpanda: Convert service.loadbalancer.yaml to go code #1215

chrisseto opened this issue Apr 18, 2024 · 0 comments · Fixed by #1347

Comments

@chrisseto
Copy link
Contributor

chrisseto commented Apr 18, 2024 •
edited by jira bot
Loading

JIRA Link: K8S-161
@chrisseto chrisseto mentioned this issue Apr 18, 2024
Open
chrisseto added a commit that referenced this issue Jun 12, 2024
@chrisseto
redpanda: convert service.loadbalancer.yaml to go
febd052 
Fixes #1215
@chrisseto chrisseto mentioned this issue Jun 12, 2024
Merged
chrisseto added a commit that referenced this issue Jun 13, 2024
@chrisseto
redpanda: convert service.loadbalancer.yaml to go
57dbee4 
This commit converts `service.loadbalancer.yaml` to go code.

It includes a small fix for a typo that seems to have gone unnoticed. In the
case of using a loadbalancer service, `listeners.admin.external[*].port` was
being ignored in favor of `listeners.admin.external.port`, which was divergent
from all other port mappings.

Fixes #1215
chrisseto added a commit that referenced this issue Jun 13, 2024
@chrisseto
redpanda: convert service.loadbalancer.yaml to go
98cef42 
This commit converts `service.loadbalancer.yaml` to go code.

It includes a small fix for a typo that seems to have gone unnoticed. In the
case of using a loadbalancer service, `listeners.admin.external[*].port` was
being ignored in favor of `listeners.admin.external.port`, which was divergent
from all other port mappings.

Fixes #1215
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

redpanda: convert service.loadbalancer.yaml to go redpanda-data/helm-charts
1 participant
@chrisseto