Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redpanda: implement snapshot testing #1079

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Conversation

chrisseto
Copy link
Contributor

This commit implements golden/snapshot based testing for the redpanda chart by leveraging all the test files in ci and placing the resultant YAML into testdata.

It includes a minor fix to _configmap.tpl that caused some non-determinism. For other sources, --set flags are specified to work around them.

@chrisseto chrisseto force-pushed the chris/snapshot-testing branch 2 times, most recently from e3664de to 4369bc5 Compare March 13, 2024 21:30
@chrisseto chrisseto enabled auto-merge (rebase) March 15, 2024 20:37
This commit implements golden/snapshot based testing for the redpanda
chart by leveraging all the test files in `ci` and placing the resultant
YAML into `testdata`.

It includes a minor fix to `_configmap.tpl` that caused some
non-determinism. For other sources, `--set` flags are specified to work
around them.
Copy link
Contributor

@alejandroEsc alejandroEsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chrisseto chrisseto merged commit ef70ab8 into main Mar 18, 2024
29 checks passed
@chrisseto chrisseto deleted the chris/snapshot-testing branch March 18, 2024 18:02
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants