Skip to content

Commit

Permalink
rpk: disable tune checkers in rp start unit test
Browse files Browse the repository at this point in the history
It doesn't make much sense to run the checkers in
a memory backed filesystem (Afero.MemMapFs) during
the unit test.

Unit tests for checkers are in rpk/pkg/tuners
  • Loading branch information
r-vasquez committed Jul 28, 2022
1 parent cade728 commit 241da98
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/go/rpk/pkg/cli/cmd/redpanda/start_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1428,7 +1428,10 @@ func TestStartCommand(t *testing.T) {
var out bytes.Buffer
logrus.SetOutput(&out)
c := NewStartCommand(fs, launcher)
c.SetArgs(tt.args)
// We disable --check flag to avoid running tuner checks in Afero's
// memory backed file system.
args := append([]string{"--check=false"}, tt.args...)
c.SetArgs(args)
err := c.Execute()
if tt.expectedErrMsg != "" {
require.Contains(st, err.Error(), tt.expectedErrMsg)
Expand Down

0 comments on commit 241da98

Please sign in to comment.