Skip to content

Commit

Permalink
redpanda: shutdown quota manager after kafka server is stopped
Browse files Browse the repository at this point in the history
Quota manager refrence is a part of request context. We need to make
sure that quota manager is available as long as the kafka server is
running. Moved quota manager initialization before waiting for Kafka
server shutdown to make sure that its reference is available for all
requests that are being processed.
  • Loading branch information
mmaslankaprv committed Apr 5, 2022
1 parent 21c358d commit 3253995
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions src/v/redpanda/application.cc
Original file line number Diff line number Diff line change
Expand Up @@ -708,6 +708,11 @@ void application::wire_up_redpanda_services() {
_rpc.stop().get();
}
});

// metrics and quota management
syschecks::systemd_message("Adding kafka quota manager").get();
construct_service(quota_mgr).get();

_deferred.emplace_back([this] {
if (_kafka_server.local_is_initialized()) {
_kafka_server.invoke_on_all(&net::server::wait_for_shutdown).get();
Expand Down Expand Up @@ -854,9 +859,6 @@ void application::wire_up_redpanda_services() {
coprocessing->start().get();
}

// metrics and quota management
syschecks::systemd_message("Adding kafka quota manager").get();
construct_service(quota_mgr).get();
// rpc
ss::sharded<net::server_configuration> rpc_cfg;
rpc_cfg.start(ss::sstring("internal_rpc")).get();
Expand Down

0 comments on commit 3253995

Please sign in to comment.