Skip to content

Commit

Permalink
tests: shut down node after decom in nodes_decommissioning_test
Browse files Browse the repository at this point in the history
Once we improve redpanda to make decommed nodes stop serving
Kafka traffic, this won't be necessary.  Right now, redpanda
does require that decommed nodes are stopped in order to avoid
confusing clients, so the test should do that.

Fixes #3277
  • Loading branch information
jcsp committed Jul 28, 2022
1 parent f865a94 commit 5d80c90
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions tests/rptest/tests/nodes_decommissioning_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,13 @@ def test_decommissioning_working_node(self):
timeout_sec=120,
backoff_sec=2)

# Stop the decommissioned node, because redpanda internally does not
# fence it, it is the responsibility of external orchestrator to
# stop the node they intend to remove.
# This can be removed when we change redpanda to prevent decommissioned nodes
# from responding to client Kafka requests.
self.redpanda.stop_node(to_decommission)

self.run_validation(enable_idempotence=False, consumer_timeout_sec=45)

@cluster(num_nodes=6, log_allow_list=CHAOS_LOG_ALLOW_LIST)
Expand Down

0 comments on commit 5d80c90

Please sign in to comment.