Skip to content

Commit

Permalink
tests: fix upgrade_test
Browse files Browse the repository at this point in the history
Upgrade test started failing because older versions of redpanda don't
support the partition_autobalancing_mode flag (that was added to default
config instead of the deprecated enable_auto_rebalance_on_node_add flag.
Looks like the only tests that need a non-default value are
node_operations_fuzzy_test (that sets it explicitly) and scaling_up_test
(where we explicitly set the value)..
  • Loading branch information
ztlpn committed Jul 12, 2022
1 parent 14647aa commit 6d9fe61
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
1 change: 0 additions & 1 deletion tests/rptest/services/redpanda.py
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,6 @@ class RedpandaService(Service):
'default_topic_partitions': 4,
'enable_metrics_reporter': False,
'superusers': [SUPERUSER_CREDENTIALS[0]],
'partition_autobalancing_mode': 'node_add_remove'
}

logs = {
Expand Down
10 changes: 8 additions & 2 deletions tests/rptest/tests/scaling_up_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,14 @@ class ScalingUpTest(EndToEndTest):
"""
@cluster(num_nodes=5)
def test_adding_nodes_to_cluster(self):
self.redpanda = RedpandaService(
self.test_context, 3, extra_rp_conf={"group_topic_partitions": 1})
self.redpanda = RedpandaService(self.test_context,
3,
extra_rp_conf={
"group_topic_partitions":
1,
"partition_autobalancing_mode":
"node_add_remove"
})
# start single node cluster
self.redpanda.start(nodes=[self.redpanda.nodes[0]])
# create some topics
Expand Down

0 comments on commit 6d9fe61

Please sign in to comment.