Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpk: typesafe defaults for RPK #1067

Closed
emaxerrno opened this issue Apr 5, 2021 · 2 comments
Closed

rpk: typesafe defaults for RPK #1067

emaxerrno opened this issue Apr 5, 2021 · 2 comments
Assignees
@twmb
Labels
area/rpk good first issue Good for newcomers kind/enhance New feature or request

Comments

@emaxerrno
Copy link
Contributor

I think it's easier to read and more type-safe as a concrete type, so yeah. Then this function would be replaced with toMap(Default())

Originally posted by @BenPope in #1066 (comment)
@emaxerrno emaxerrno mentioned this issue Apr 5, 2021
Merged
@emaxerrno emaxerrno added area/rpk good first issue Good for newcomers kind/enhance New feature or request labels Apr 5, 2021
@twmb twmb assigned twmb and unassigned 0x5d Oct 5, 2021
@twmb
Copy link
Contributor

twmb commented Oct 5, 2021

This will be automatically done when some of my currently in-progress refactoring is complete.

@twmb
Copy link
Contributor

twmb commented May 3, 2022

Closing in favor of #4531

@twmb twmb closed this as completed May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@twmb twmb

Labels
area/rpk good first issue Good for newcomers kind/enhance New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@emaxerrno @twmb @0x5d