rpk: Enable pandaproxy by default #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Pope <ben@vectorized.io>
Signed-off-by: Ben Pope <ben@vectorized.io>
BenPope
requested review from
0x5d,
bmansheim,
dotnwat and
mmaslankaprv
as code owners
BenPope
requested review from
dimitriscruz and
alenkacz
and removed request for
mmaslankaprv
0x5d
approved these changes
Apr 5, 2021
0x5d
reviewed
Apr 5, 2021
| @@ -87,6 +87,7 @@ func defaultMap() map[string]interface{} { | |||
| var defaultListeners []interface{} = []interface{}{defaultListener} | |||
| return map[string]interface{}{ | |||
| "config_file": "/etc/redpanda/redpanda.yaml", | |||
| "pandaproxy": Pandaproxy{}, | |||
There was a problem hiding this comment.
Should we make all these concrete types instead of maps? (not in this PR of course)
There was a problem hiding this comment.
I think it's easier to read and more type-safe as a concrete type, so yeah. Then this function would be replaced with toMap(Default())
There was a problem hiding this comment.
I created a ticket #1067 to track this.
mmedenjak
added
area/pandaproxy
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
Enable pandaproxy by default
Release notes
Release note: Pandaproxy - listen on all interfaces and enable by default