-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator/config: additionalConfiguration fields convert large integers to scientific notation #2103
Comments
Thanks @cscorley ! Good report. We’ll fix. Let us know if you want to take a pass at the code. Should be chasing the types as strings on the config parser. Cc @dimitriscruz |
I don't think I'm apt to change it (I'm very unfamiliar with Go). I took a swing at locating the bug while trying to debug my issue, but I am not sure about the solution. I think the configuration is being unmarshaled as JSON by default here: https://github.com/vectorizedio/redpanda/blob/d4165f1af5233448733ab5c1b481457a5d5ee4fe/src/go/rpk/pkg/config/manager.go#L344 |
The operator calls the rpk package, which parses the configuration. Afaik the parsing is eventually handled by the viper library (called by rpk). I suspect that because "delete_retention_ms" isn't part of the rpk schema, but is part of "Other" ( I tried adding the following test case under rpk's
(requiring Perhaps @0x5d or @twmb have some idea on how to handle this on the rpk side, or we could have redpanda handle this notation as well. |
Oh good catch with viper/rpk |
@senior7515 this is still an issue in the latest release. Just thought I'd reach out in case it was forgotten! |
#5061 removed viper library and fixed this issue, now rpk won't convert large integers to scientific notation. This will be in the upcoming v22.2 release |
Hi team,
I have ran into an issue where providing a large integer (such as an ms value) would generate a redpanda configuration YAML that is not parsable by redpanda.
For instance, the following cluster definition:
This causes the following error on boot:
The problematic configuration line being:
delete_retention_ms: 6.048e+08
The text was updated successfully, but these errors were encountered: