Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpk outputs scientific notation for large integer config values #5249

Closed
ajfabbri opened this issue Jun 27, 2022 · 2 comments
Closed

rpk outputs scientific notation for large integer config values #5249

ajfabbri opened this issue Jun 27, 2022 · 2 comments
Labels
area/rpk kind/bug Something isn't working

Comments

@ajfabbri
Copy link
Contributor

ajfabbri commented Jun 27, 2022

Version & Environment

Redpanda / RPK version: 22.1.4 on linux.

Found when working on #4850, my test code had to special case output of a large value because it was printed by RPK in scientific notation (link).

A quick search found these maybe-related issues: #2103 #2620 #3082

@ajfabbri ajfabbri added the kind/bug Something isn't working label Jun 27, 2022
@twmb
Copy link
Contributor

twmb commented Jul 7, 2022

Pinging @r-vasquez to check if this has been fixed with the recent merge removing viper,
which, if so, may also fix the issues linked above (thanks for the spelunking)

@r-vasquez
Copy link
Contributor

r-vasquez commented Jul 7, 2022

Hello @ajfabbri

#5061 fixed this issue and is in the upcoming v22.2 release, now:

$ rpk redpanda config set redpanda.delete_retention_ms 6048000001234123

will produce:

$ cat /etc/redpanda/redpanda.yaml                                                         
node_uuid: SBuBZ2HhHUvQQPdKF5UCD84JHmU3T3y9mbPFq1s2q7STAGBCM
config_file: /etc/redpanda/redpanda.yaml
redpanda:
    data_directory: /var/lib/redpanda/data
    node_id: 1
    seed_servers: []
    rpc_server:
        address: 0.0.0.0
        port: 33145
    kafka_api:
        - address: 0.0.0.0
          port: 9092
    admin:
        - address: 0.0.0.0
          port: 9644
    developer_mode: true
    delete_retention_ms: 6048000001234123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rpk kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants