rpk redpanda admin config log-level set all ... does not include all loggers

[oschrenk]

Version & Environment

Redpanda version: (use rpk version):

What went wrong?

I used rpk redpanda admin config log-level set --level info --expiry-seconds 300 all --host 0 to set my log level. I thought all would mean ALL loggers and indeed it includes many as seen by by the response of the command:

redpanda@redpanda-0:/$ rpk redpanda admin config log-level set --level info --expiry-seconds 31536000 all --host 0
SUCCESSES
admin_api_server
archival
assert
cloud_storage
cluster
compaction_ctrl
compression
coproc
dns_resolver
exception
fault_injector
http
httpd
io
kafka
kvstore
pandaproxy
raft
redpanda::main
rpc
s3
scheduler
scollectd
seastar
security
storage
syschecks

But I still see the following log messages:

DEBUG 2022-02-09 11:31:08,113 [shard 0] storage-gc - disk_log_impl.cc:241 - [{kafka/jobs/0}] gc[time_based_retention] requested to remove segments up to -9223372036854775808 offset

If I issue it separately I get a success in setting it:

rpk redpanda admin config log-level set --level info --expiry-seconds 300 storage-gc --host 0
SUCCESSES
storage-gc

I assume is missing from the all list of loggers.

What should have happened instead?

Setting log levels for all should set all.

How to reproduce the issue?

See above

Additional information

I brought the topic up in Slack https://redpandacommunity.slack.com/archives/C01AJDUT88N/p1644406549742039 which seem to confirm the suspicion

It's likely missing storage-gc in the list of possible loggers https://github.com/redpanda-data/redpanda/blob/dev/src/go/rpk/pkg/cli/cmd/redpanda/admin/config/config.go#L174

I don’t think that log type existed when the initial list was added, it should be added now. I don’t think redpanda has an API endpoint to return all available loggers (the best we have I think is redpanda --help-loggers IIRC… perhaps rpk can invoke redpanda for the list)

JIRA Link: CORE-840

[emaxerrno]

awesome! thanks @oschrenk ! great report.