Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InvalidConfigurationException when setting confs back to Redpanda #4310

Closed
daisukebe opened this issue Apr 18, 2022 · 2 comments · Fixed by #4313
Closed

InvalidConfigurationException when setting confs back to Redpanda #4310

daisukebe opened this issue Apr 18, 2022 · 2 comments · Fixed by #4313
Assignees
Labels
kind/bug Something isn't working

Comments

@daisukebe
Copy link
Contributor

daisukebe commented Apr 18, 2022

Version & Environment

Redpanda version: v21.11.12 (also existing in dev 248e103)

What went wrong?

Kafka clients, e.g. KSQL, that do get the confs from a topic and re-applying the same configuration object to a topic throws the following exception:

Exception in thread “main” java.util.concurrent.ExecutionException: org.apache.kafka.common.errors.InvalidConfigurationException: invalid topic property: redpanda.datapolicy
	at org.apache.kafka.common.internals.KafkaFutureImpl.wrapAndThrow(KafkaFutureImpl.java:45)
	at org.apache.kafka.common.internals.KafkaFutureImpl.access$000(KafkaFutureImpl.java:32)
	at org.apache.kafka.common.internals.KafkaFutureImpl$SingleWaiter.await(KafkaFutureImpl.java:89)
	at org.apache.kafka.common.internals.KafkaFutureImpl.get(KafkaFutureImpl.java:260)
	at com.gaincapital.messaging.camel.KafkaAdmin.main(KafkaAdmin.java:30)
Caused by: org.apache.kafka.common.errors.InvalidConfigurationException: invalid topic property: redpanda.datapolicy

This is because Redpanda has our own confs being rejected. Both alterConfig and incrementalAlterConfigs encounter this.

What should have happened instead?

The request should succeeds.

How to reproduce the issue?

  1. Get the topic confs via describeConfigs
  2. Set it back to the topic via alterConfigs or incrementalAlterConfigs
@daisukebe daisukebe added the kind/bug Something isn't working label Apr 18, 2022
@daisukebe daisukebe added this to the v21.11.13 milestone Apr 18, 2022
@ZeDRoman
Copy link
Contributor

I have found out that the problem is how we describe redpanda.datapolicy
Originally we have two parameters for datapolicy: redpanda.datapolicy.function.name and redpanda.datapolicyscript.name
We can set them with alter topic configs.
But in describe topic config we return these parameters as redpanda.datapolicy=function_name: {val} script_name: {val}
That is why after describing config we send alter config request with invalid propery.

Also we ahve two more properties that are described but can't be set in alter_config: partition_count and replication_factor.
We should add these properties to noop list

@ZeDRoman
Copy link
Contributor

/backport v21.11.x

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants