Add properties that are returned from topic describe config to noop list #4313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add properties that are returned from topic describe config to noop list
esteban
reviewed
Apr 18, 2022
Comment on lines
+65
to
+69
| "partition_count", | ||
| "replication_factor", | ||
| // Invalid name from describe | ||
| "redpanda.datapolicy", | ||
|
|
There was a problem hiding this comment.
Note: I think it should be fine for now but having a way to annotate the scope of each property would be nice to have just to make this better in the future.
There was a problem hiding this comment.
we can also make this a ctre ... something like this https://godbolt.org/z/5PcbEWz8s
esteban
reviewed
Apr 18, 2022
Comment on lines
+75
to
+78
| topic = self.topics[0].name | ||
| kafka_tools = KafkaCliTools(self.redpanda) | ||
| topic_config = kafka_tools.describe_topic_config(topic=topic) | ||
| self.client().alter_topic_configs(topic, topic_config) |
There was a problem hiding this comment.
Nice! this should help to catch this kind of issues in the future.
esteban
approved these changes
Apr 18, 2022
graphcareful
approved these changes
Apr 18, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
Fixes #4310
Release notes
Accept partition_count, replication_factor and redpanda.datapolicy in alter config handler