Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics cardinality reduction #4728

Closed
dotnwat opened this issue May 13, 2022 · 3 comments
Closed

Metrics cardinality reduction #4728

dotnwat opened this issue May 13, 2022 · 3 comments
Assignees
Labels

Comments

@dotnwat
Copy link
Member

dotnwat commented May 13, 2022

PRD: https://docs.google.com/document/d/13q3BgBxD518hLqBooubTw4RYu3M6d6F22o05XuVedCU/edit
RFC: https://docs.google.com/document/d/1TxaJiNIyMAHr3cNpebd9K4wylih4jviFqv5-JuR-FDw/edit

Scope:

  • Create a new prometheus metrics endpoint including the metrics requested in the PRD and having a much lower cardinality than the old endpoint (no per-shard metrics unless we actively want that for particular metrics, and minimal per-partition or per-topic metrics).
  • Document all metrics that are included in the new metrics endpoint
  • Make old endpoint optional, but enabled by default for backward compatibility.
  • Test at scale, e.g. a cluster with 10,000 partitions. Consider extending ManyPartitionsTest to include a rough check on the metrics count, so that if we accidentally increase it later a test will fail.

Out of scope:

  • Any output format other than prometheus
  • Any optimization or other improvement of the existing metrics endpoint
  • Any configurability of what's included in the new metrics endpoint (it's all or nothing).
@BenPope
Copy link
Member

BenPope commented May 20, 2022

Some PoC code for configuration and aggregation of existing metrics: #4843

@BenPope
Copy link
Member

BenPope commented May 23, 2022

Hey team! Please add your planning poker estimate with ZenHub @BenPope @NyaliaLui

@BenPope
Copy link
Member

BenPope commented Jun 27, 2022

This has been replaced by a different mechanism.

@BenPope BenPope closed this as completed Jun 27, 2022
@mmedenjak mmedenjak added kind/enhance New feature or request area/redpanda labels Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants