Metrics Cardinality Reduction: PoC #4843
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Pope <ben@redpanda.com>
jcsp
reviewed
May 23, 2022
|
|
||
| // Collect aggregated instances | ||
| metric_multi_instance new_instances; | ||
| for (const auto& [base_labels, base_metric] : family) { |
There was a problem hiding this comment.
There is an efficiency issue here for large partition counts: we'd be iterating over ~10E5 partition labels and summing them all up, plus the allocation overhead of building these intermediate vectors of metrics.
There was a problem hiding this comment.
There are two phases:
- This code that allocates runs at (re)configuration time, and can be made async if required.
- The aggregations happens at scrape time, and would indeed involve iteration and indirection.
|
Decided on a different direction: #5166 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
This is a PoC of filtering existing metrics with the following features:
From the code that exists it has some weaknesses:
Release notes