-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: Update offline_log_viewer for serde-encoded controller logs & test it #5293
Comments
visibility for @felixguendling |
Related: a small start on hooking this tool into automated tests is in #5315 |
A bunch of offline_log_viewer stuff merged since this ticket was last updated - is there still work to do? |
@andijcr ^? |
cmd removing entries from test files i get this file serde_versions_mods.txt that should contains the changes where serde::version is incremented. i'll run down this later to check if something is missing |
The log decoder in
tools/offline_log_viewer
is a very useful diagnostic. It has some hand-crafted decoding logic for decoding some controller log messages into JSON.In 22.2, when the serde_raft_0 feature flag activates after upgrade, we'll start writing controller messages in a new serde encoding (instead of old ADL).
The metadata_viewer tool needs to understand both encodings, because upgraded systems will have a mixture of encodings in their controller logs.
This is a good time to add an automated ducktape test for the tool, that runs a cluster through some administrative operations and then checks the tool can decode the resulting controller log.
The text was updated successfully, but these errors were encountered: