Feature: offline_log_viewer updates #6233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…header.type instead of batch.type)
…er.read_envelope to accept a type_read Callable[rdr: Reader, version: Int]: Dict and a max_version parameter.
If a type_read is used, it is invoked with reader and envelope if envelope.version <= max_version parameter.
the result is joined with a dict {'envelope': envelope} and returned, otherwise an error dict is returned.
If no type_read is used, envelope is returned immediately
andijcr
force-pushed
the
feat/offline_log_viewer_updates
branch
from
263c60d
to
885238d
Compare
the new code tries to mimic the structure of the adl decoding functions. the new code is aware of the version number embedded in the binary stream and will skip the field if the version is not supported, while reporting the error.
…update_command) and decode_node_management_command
…rocessed
in case of unread byte, an 'unread': {'k': ..., 'v': ...} field is added and an error is logged
this check is not exact but is a good proxy to know if the decoding code is correct
…r.skip() for unused fields
andijcr
force-pushed
the
feat/offline_log_viewer_updates
branch
from
885238d
to
a5de788
Compare
dotnwat
reviewed
Sep 8, 2022
|
(didn't review the code but I notice the commit messages aren't in the usual format: see CONTRIBUTING.md in the source and/or take a peek at the commit history) |
|
@andijcr this has been stalled for a while -- it's not our top priority, but it would be good to know if there were issues blocking this |
|
I've merged this into #5315 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
These changes add a first support in tools/offlile_log_viewer for serde-encoded controller messages.
running
will decode logs produced by v22.2 and earlier. serde commands start with a field 'envelope' that contains
[version, compat_version, encoded_size].Partially fixes #5293,
implements:
open questions:
Backport Required
UX changes
messages are decoded in a stream of json files. the schema for adl encoded files is unchanged, but the schema for serde - encoded message is different in some places than the corresponding adl-one, reflecting more the hierarchical data organization.
Release notes