[v23.1.x] Put consumers in their own scheduling group #10410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By analogy with smp_groups which is already public we need to access this outside of application.cc to pass the right scheduling groups through to instantiations of services in our redpanda fixture. (cherry picked from commit d505693)
This scheduling group is used for consumer fetch processing. We assign it the same priority as the default group (where most other kafka handling takes place), but by putting it into its own group we prevent non-fetch requests from being significantly delayed when fetch requests use all the CPU. Issue redpanda-data/core-internal#435 (cherry picked from commit d133843)
Add the with_scheduling_group call to switch to the kafka scheduling group in the fetch handling flow. See prior change for context. Issue redpanda-data/core-internal/redpanda-data#435. (cherry picked from commit 9a93a9c)
Introduce a config tunable which would let users set the scheduling group to use for kafka fetch request back to the default group. Also useful for quick A/B testing of the perf effect of the change. (cherry picked from commit bc72f5e)
mmaslankaprv
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #10398
Release Notes