cloud_storage: fix empty segment check in reader #10782
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was incorrectly offsetting the next kafka offset by 1. A segment with kafka data in it has a next offset != its base offset, while a segment _without_ kafka data has a next offset == its base offset. This was ignored by unit tests because the tests were using segment name format v1 which ignores delta_offset_end, and ignored by integration tests because if our reader path drops out then the client will retry, and because it only causes the problem if a segment has exactly one data batch in it.
jcsp
added
kind/bug
andijcr
approved these changes
May 15, 2023
7 tasks
This was referenced May 17, 2023
|
/backport v23.1.x |
|
/backport v22.3.x |
|
The pull request is not merged yet. Cancelling backport... |
|
The pull request is not merged yet. Cancelling backport... |
This was referenced May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was incorrectly offsetting the next kafka offset by 1.
A segment with kafka data in it has a next offset != its base offset, while a segment without kafka data has a next offset == its base offset.
This was ignored by unit tests because the tests were using segment name format v1 which ignores delta_offset_end, and ignored by integration tests because if our reader path drops out then the client will retry, and because it only causes the problem if a segment has exactly one data batch in it.
Backports Required
Release Notes