Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v22.3.x] cloud_storage: fix empty segment check in reader #10869

Commits on May 18, 2023

  1. cloud_storage: fix empty segment check in reader

    This was incorrectly offsetting the next kafka offset
    by 1.
    
    A segment with kafka data in it has a next offset != its
    base offset, while a segment _without_ kafka data has a next
    offset == its base offset.
    
    This was ignored by unit tests because the tests were
    using segment name format v1 which ignores delta_offset_end,
    and ignored by integration tests because if our reader path
    drops out then the client will retry, and because it only
    causes the problem if a segment has exactly one data
    batch in it.
    
    (cherry picked from commit 92cbc1a)
    jcsp authored and michael-redpanda committed May 18, 2023
    Configuration menu
    Copy the full SHA
    e432391 View commit details
    Browse the repository at this point in the history