[v23.1.x] Removed lock contention when writing Raft snapshots #10973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When writing a snapshot Raft uses the state that is a part of already committed log, offset translator and configuration manager. The snapshot does not relay on the protocol state that mutates. This observation allows to write snapshot outside of Raft operation mutex as that operation is not changing any of the current state and does not relay on the current state. Using separate mutex to protect the snapshot reduces contention and does not influence the write path latency. Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit 8b21874)
When prefix truncating configuration manager and offset translator the main raft operation mutex doesn't have to be held. Prefix truncation only mutates the state that is no longer changed by any other operation than persisting a snapshot. It is enough to make the operation mutually exclusive with other snapshot related operations. Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit 54fc7cd)
|
ci failure: #10219 |
bharathv
approved these changes
May 24, 2023
This was referenced Dec 19, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #10870