Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v23.1.x] add pre-exit hook that calls the vtools one #10999

Merged

Conversation

gousteris
Copy link
Contributor

@gousteris gousteris commented May 24, 2023

Backport of #10879

Release Notes

  • none

fixes #10996

Currently the bk hooks are defined in the vtools
repo and they are moved to the redpanda pipeline
at runtime. We shouldn't move hooks in CI as it
causes git to report a diff. This causes the
-dirty suffix to be present when running
redpanda --version

ref
redpanda-data/vtools#1753
redpanda-data/vtools#1760 (comment)

(cherry picked from commit 0975945)
It is currently used for running ci repeat
by adding a label on the PR. This feature
was replaced with the `/ci-repeat` command

(cherry picked from commit e817310)
@gousteris gousteris linked an issue May 24, 2023 that may be closed by this pull request
@gousteris gousteris changed the title Backport fixes to v23.1.x 510 [v23.1.x] add pre-exit hook that calls the vtools one May 24, 2023
@vshtokman vshtokman added this to the v23.1.x-next milestone May 24, 2023
@gousteris gousteris requested review from a team and andrewhsu and removed request for a team May 25, 2023 15:50
Copy link
Member

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gousteris gousteris merged commit c066d6b into redpanda-data:v23.1.x May 26, 2023
@vshtokman vshtokman modified the milestones: v23.1.x-next, v23.1.12 Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v23.1.x] add pre-exit hook that calls the vtools one
3 participants