[v23.1.x] storage: maybe_yield when building a batch in kvstore::save_snapshot
#11927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function passed to `for_each_record_async` might not return a future. This is the case when for_each_record_async` is used primary for the purpose of yeilding, rather than to accept an async function. `futurize_invoke` the passed function so that the call site doesn't have to be modified. Signed-off-by: Ben Pope <[email protected]> (cherry picked from commit e24eb39)
This is necessary for the next commit. Signed-off-by: Ben Pope <[email protected]> (cherry picked from commit 68d951b)
54c0a3f made the serialization of the batch async, but it's possible for the batch builder to also cause reactor stalls, as seen on a live system running v23.1.12 (of about 150ms) Add a mutex to protect _db and _next_offset * `maybe_yield` in the builder loop to avoid reactor stalls whilst saving * Use `for_each_record_async` to avoid reactor stalls whilst loading * Use `for_each_record_async` to avoid reactor stalls whilst replaying Signed-off-by: Ben Pope <[email protected]> (cherry picked from commit 310fb33)
BenPope
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #11809