Backport of #12063 v23.1.x #12086
Merged
Backport of #12063 v23.1.x #12086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graphcareful
requested review from
dotnwat,
andrwng,
mmaslankaprv and
michael-redpanda
- If the user attempts to make a offset_for_leader_epoch request where the requested epoch is ahead of the latest known, the response should contain -1s for requested epoch and end_offset. - Fixes: redpanda-data#11864 (cherry picked from commit d7184ee)
- offset_for_leader_epoch requests were unconditionally returning the current leader epoch. - The correct behavior is to return the requested epoch, as seen here: https://github.com/apache/kafka/blob/3.5.0/storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java#L276-L282 - Fixes: redpanda-data#11864 (cherry picked from commit fe5ad6c)
- Ensure that the returned epoch end offset is -1 for requested epoch's that are in the future. - Ensure that the returned leader epoch is not the current epoch but actually the requested epoch. (cherry picked from commit 1d5d6de)
graphcareful
force-pushed
the
backport-pr-12063-v21.1.x
branch
from
3018539
to
bffeb2e
Compare
mmaslankaprv
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #12063