[v23.1.x] c/rm_stm: fixed returning incorrect max_collectible_offset
#12190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An off by one error in `rm_stm::max_collectible_offset` may lead to situation in which an stm couldn't continue. If `max_collectible_offset` returned last offset in the segment it may lead to the situation in which the whole segment was evicted before its last entry was applied. As the `max_collectible_offset` was returning `last_stable_offset` which indicates the offset for which all _previous_ offsets are decided (has no pending transactions and have been committed). In rare cases it may lead to situation where a segment ending at offset `n` was removed even though only `n - 1` was decided. Signed-off-by: Michal Maslanka <[email protected]> (cherry picked from commit 70541df)
rystsov
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #12176