[v23.1.x] schema_registry: Improve sanitization of Avro namespaces #12425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass a context instead of just a memoryt allocator. Signed-off-by: Ben Pope <[email protected]> (cherry picked from commit 312817c)
If the name field is a fullname, then an existing namespace is ignored. Sanitize splits the fullname into name and namespace, so rewrite the namespace rather than returning an error. Reference: https://avro.apache.org/docs/1.11.1/specification/#names Signed-off-by: Ben Pope <[email protected]> (cherry picked from commit 29af7c8)
Check that simple namespace cases are left alone. Signed-off-by: Ben Pope <[email protected]> (cherry picked from commit 6e7c061)
This PR keeps track of the current namespace in a stack, starting with the implicitly null "empty" namespace. If the namespace changes, push it to the stack. If a namespace is redundant (the same as outer scope), remove it. Fixes redpanda-data#11912 Signed-off-by: Ben Pope <[email protected]> (cherry picked from commit 9cfd7bd)
Signed-off-by: Ben Pope <[email protected]> (cherry picked from commit d73b2c8)
BenPope
added
area/schema-registry
michael-redpanda
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #12334
Fixes: #12415,
Manual backport because
<stack>wasn't includedCloses #12417