Incremental fetch support #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you rebase w/ dev |
mmaslankaprv
force-pushed
the
incremental-fetch-support
branch
from
0a57652
to
f8297f2
Compare
|
@mmaslankaprv merge conflict |
mmaslankaprv
force-pushed
the
incremental-fetch-support
branch
from
f8297f2
to
9c43c12
Compare
|
@senior7515 @dotnwat rebased. |
dotnwat
requested changes
Nov 24, 2020
src/v/model/fundamental.h
Outdated
| topic_partition() = default; | ||
| topic_partition(model::topic t, model::partition_id i) | ||
| : topic(std::move(t)) | ||
| , partition(i) {} | ||
|
|
||
| topic_partition(model::topic_partition_view view) // NOLINT |
There was a problem hiding this comment.
why nolint? does clang tidy want explcit?
There was a problem hiding this comment.
exactly, it is complaining about explicit
There was a problem hiding this comment.
from what type are we taking implicit conversions?
There was a problem hiding this comment.
When I think of it this conversion i.e. topic_partition_view -> topic_partition as it involves copying.
emaxerrno
reviewed
Nov 24, 2020
src/v/kafka/fetch_session.h
Outdated
| + partitions.size() * sizeof(fetch_partition); | ||
| } | ||
|
|
||
| underlying_t::iterator begin() { return partitions.begin(); } |
There was a problem hiding this comment.
use type alias at the top.
also define begin() const and end() const
see iobuf for alias examples.
|
clang-release ci on google cloud build |
mmaslankaprv
force-pushed
the
incremental-fetch-support
branch
2 times, most recently
from
b953d42
to
ab1ffc4
Compare
mmaslankaprv
force-pushed
the
incremental-fetch-support
branch
2 times, most recently
from
ff998bc
to
4d8b90b
Compare
Introduced `model::topic_partition_view` to avoid excessive topic_partition copying. Signed-off-by: Michal Maslanka <michal@vectorized.io>
Introduced `kafka::fetch_session` type. The `fetch_session` represents a single session maintained in memory on server for a consumer. Maintaining a list of partition that consumer is interested in on the server sides allow to reduce overhead of transmitting the whole partitions list between server and consumer every time the consumer fetches data. Signed-off-by: Michal Maslanka <michal@vectorized.io>
Added configuration option for controlling fetch session eviction timeout. i.e. the time after inactive session is being evicted. Signed-off-by: Michal Maslanka <michal@vectorized.io>
Implemented fetch session cache. Fetch session cache is a core local cache holding incremental fetch sessions. Each core local cache instance assigns session ids that are unique for the node (non overlapping ranges of ids are assigned to each core). The cache evicts not used sessions after configurable period of inactivity. Fetch session cache will stop adding new sessions after its max memory usage is reached. Signed-off-by: Michal Maslanka <michal@vectorized.io>
When processing the fetch request we have to be able to access core local fetch sessions cache. Added the sessions cache to `kafka::request_context`. Signed-off-by: Michal Maslanka <michal@vectorized.io>
Using the fetch sessions cache to implement incremental fetch requests handling. Caching fetch sessions allow to reduce overhead of sending whole list of partitions every time consumer issues the fetch request. Signed-off-by: Michal Maslanka <michal@vectorized.io>
Signed-off-by: Michal Maslanka <michal@vectorized.io>
mmaslankaprv
force-pushed
the
incremental-fetch-support
branch
from
4d8b90b
to
838e887
Compare
dotnwat
approved these changes
Nov 25, 2020
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incremental fetch handing in redpanda.
Fixes #25
Checklist
When referencing a related issue, remember to migrate duplicate stories from the
external tracker. This is not relevant for most users.