iceberg: add non-codegened manifest_list implementation #23096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrwng
force-pushed
the
iceberg-manifest-list
branch
2 times, most recently
from
4cebcbc
to
0d7ec0e
Compare
andrwng
force-pushed
the
iceberg-manifest-list
branch
2 times, most recently
from
ff414f6
to
26933fd
Compare
dotnwat
reviewed
Aug 28, 2024
andrwng
force-pushed
the
iceberg-manifest-list
branch
3 times, most recently
from
74bbe3b
to
b170e9c
Compare
dotnwat
previously approved these changes
Aug 29, 2024
The avrogen::manifest_file is pretty difficult to operate on, on account of Avro's codegen heavily using std::any and representing optional values as unions. To manifest list operations easier (and to decouple metadata from the Avro library) this introduces a manifest_list class that uses simpler types to represent metadata. This doesn't introduce any serialization code. That will come in a subsequent commit.
Calls into the avrogen serialization of avrogen::manifest_files but with the members of the non-avrogen manifest_files.
andrwng
force-pushed
the
iceberg-manifest-list
branch
from
b170e9c
to
cd39508
Compare
jcipar
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The avrogen::manifest_file is pretty difficult to operate on, on account
of Avro's codegen heavily using std::any and representing optional
values as unions. To manifest list operations easier (and to decouple
metadata from the Avro library) this introduces a manifest_list class
that uses simpler types to represent metadata.
Calls into the avrogen serialization of avrogen::manifest_files but with
the members of the non-avrogen manifest_files.
Backports Required
Release Notes