Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: add clang-format command #23269

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

rockwotj
Copy link
Contributor

This adds a command to run clang-format using the version from our bazel
toolchain.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.2.x
  • v24.1.x
  • v23.3.x

Release Notes

  • none

This adds a command to run clang-format using the version from our bazel
toolchain.
@rockwotj rockwotj marked this pull request as ready for review September 13, 2024 03:29
Copy link
Member

@dotnwat dotnwat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got this. does it mean that i have to first build with the llvm18 toolchain?

nwatkins@acid:~/src/redpanda$ tools/clang_format.sh
readlink: missing operand
Try 'readlink --help' for more information.
~/src/redpanda ~/src/redpanda
xargs: : No such file or directory
~/src/redpanda

@rockwotj
Copy link
Contributor Author

No run it like bazel run //tools/clang_format

@dotnwat
Copy link
Member

dotnwat commented Sep 13, 2024

oh dear i should have known that :P

@rockwotj
Copy link
Contributor Author

Lolz, maybe we need better docs for this...

@rockwotj rockwotj merged commit 915b229 into redpanda-data:dev Sep 13, 2024
14 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants