rptest: Enable scrubber only if not explicitly disabled #23274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to disable scrubber in a few tests (e.g. specific scale tests, tests without a working cloud storage connection). This worked correctly until we decided to disable it by default but still wanted to keep it enabled in tests (redpanda-data@6a7ff55). I forgot to consider the fact that some tests want it disabled anyway. Update the code so that scrubber is enabled only if not explicitly disabled.
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/54313#0191e164-f961-47ec-a26a-c61694b70992 ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/54313#0191e175-92c7-4dd7-9a77-7d497cf283f6 |
abhijat
approved these changes
Sep 11, 2024
|
Unrelated failure gtest_raft_rpunit test timeout. This PR changes only ducktape tests. |
|
/backport v24.2.x |
|
/backport v24.1.x |
This was referenced Sep 12, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to disable scrubber in a few tests (e.g. specific scale tests, tests without a working cloud storage connection). This worked correctly until we decided to disable it by default but still wanted to keep it enabled in tests
(6a7ff55). I forgot to consider the fact that some tests want it disabled anyway.
Update the code so that scrubber is enabled only if not explicitly disabled.
Backports Required
Release Notes