bazel: inject git version information into version.cc #23303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockwotj
force-pushed
the
bazel-version
branch
4 times, most recently
from
d02b38a
to
3e7a6c1
Compare
dotnwat
reviewed
Sep 12, 2024
rockwotj
force-pushed
the
bazel-version
branch
from
3e7a6c1
to
4b7d6eb
Compare
Using --workspace_status_command embed the version information into the binary. The output of that script becomes a file that we can input into the build system using a custom rule that invokes a python script to write out a C++ source file with those values. This is all controlled via --config=stamp. I tried to leave lots of breadcrumbs here, but for those new to writing Bazel rules, there are two great resources, the reference docs for a rule: https://bazel.build/rules/lib/builtins/ctx and the Bazel examples found here: https://github.com/bazelbuild/examples/tree/main/rules
rockwotj
force-pushed
the
bazel-version
branch
from
4b7d6eb
to
88b9df8
Compare
dotnwat
approved these changes
Sep 12, 2024
|
Cancelling the standard CI pipeline, this only effects Bazel. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: CORE-5568
Backports Required
Release Notes