tests: fix disabling test_changing_topic_retention_with_restart #2427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related: redpanda-data#2406 Signed-off-by: John Spray <jcs@vectorized.io>
ivotron
approved these changes
Sep 24, 2021
|
@jcsp when i fixed the merge conflict it appears that this test had been unignored by some other commit, so now this PR isn't fixing the disable but rather is disabling. is that the result you want? |
|
This one raced with the underlying fix, no longer needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
Turns out that
@ignoreworks, and@ignore(param=val)works, but@ignore()does nothing.Related: #2406
Release notes
None