kafka/server: Improve kafka::map_topic_error_code v2 #2428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Pope <ben@vectorized.io>
Instead of returning `unknown_server_error`, return `not_controller` This is a retriable error code, with metadata refresh. Fixes redpanda-data#2406 Signed-off-by: Ben Pope <ben@vectorized.io>
When a new `cluster::errc` is added, a compilation error will force consideration of the mapping here. Signed-off-by: Ben Pope <ben@vectorized.io>
Signed-off-by: Ben Pope <ben@vectorized.io>
BenPope
requested review from
ivotron,
NyaliaLui and
rystsov
as code owners
BenPope
changed the title
|
I didn't see any failures in the last 9 runs on test-staging, so this should be good to go. |
BenPope
added a commit
to BenPope/redpanda
that referenced
this pull request
Sep 29, 2021
PR redpanda-data#2428 changed the returned error code so that the error was retriable with a metadata refresh, but kafka-configs.sh doesn't retry. Call describe_topic to wait for the controller, as it performs a retry. Fix redpanda-data#2406 Signed-off-by: Ben Pope <ben@vectorized.io>
This was referenced Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Let's wait for this to bake on
test-stagingfor a bit before merge.This is a copy of #2422 but buildkite didn't spot that I changed the base to dev and is failing.
Cover letter
Map
cluster::errc::no_leader_controllertokafka::error_code::not_controllerso that the error is retriable, with metadata refresh.Fixes #2406
Also:
vlogcluster::errcis introduced.See #2425 for followup work.
Release notes
Release note: redpanda/kafka: leader_not_available is now a retriable error.