rpk debug bundle: Include offset from NTP response, retry if query fails #2841
Conversation
| return err | ||
| } | ||
|
|
||
| err = retry.Do( |
There was a problem hiding this comment.
It may be faster if we use ntp.QueryWithOptions(host, ntp.QueryOptions{Timeout: time.Second}) and query a few hosts simultaneously (or the same host a few times simultaneously) and use the first successful response.
This retry loop is simple but does mean a 3s delay if there's some problems. Also I'd maybe use a for loop directly.
But this does solve the immediate issue, which is good, and any refinement can come later if needed.
There was a problem hiding this comment.
@twmb good point. However, the whole program's minimum execution time is bound by top -b -n 10 -H -d 1, which does 10 iterations with a 1-second delay between each iteration.
There was a problem hiding this comment.
Oh good point, I forgot about the top delay. Perfect then! :)
Add retries (3) for the NTP query, and include the reported offset and local time at the time the query was issued.
Fix #2802