kafka: fix Sarama control record issue #3189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VadimPlh
reviewed
Dec 8, 2021
Kafka protocol specifies that the value of a control record is dependent on the type and is opaque to clients. However some clients including Sarama depends on Kafka's implementation details See redpanda-data/connect#953 Fixing the compatibility by returning the same structure as Sarama expects. Since we pass control records to a client as is and don't look into its value the change isn't only backward compatible with previous Redpanda versions but also is a rollback safe. Fix: https://github.com/vectorizedio/support/issues/179
rystsov
force-pushed
the
commit-marker
branch
from
0635610
to
914eca3
Compare
@rystsov thanks that was my first question! by chance, do you have a reference into Kafka source where the value is constructed? |
no, I don't I used Sarama sources to deduce types (the value should be opaque so it's safe to return any value) |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
Kafka protocol specifies that the value of a control record is dependent on the type and is opaque to clients. However some clients including Sarama depends on Kafka implementation details
See redpanda-data/connect#953
Fixing the compatibility by returning the same structure as Sarama expects.
Since we pass control records to a client as is and don't look into its value the change isn't only backward compatible with previous Redpanda versions but also is a rollback safe.
Fixes: https://github.com/vectorizedio/support/issues/179
This is where Kafka formats the value:
https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/record/EndTransactionMarker.java
Release notes
Makes Redpanda transactions compatible with Sarama.