k8s: Restart redpanda after configmap changes #3262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alenkacz
force-pushed
the
av/configmap-hash-restart
branch
6 times, most recently
from
9ff4b75
to
36b6545
Compare
alenkacz
force-pushed
the
av/configmap-hash-restart
branch
4 times, most recently
from
0a40923
to
0c5eaf6
Compare
alenkacz
changed the title
|
This pull request has been linked to Shortcut Story #6518: Restart node after configmap change. |
0x5d
previously approved these changes
Dec 17, 2021
Comment on lines
175
to
177
| configMapHashGetter := func() (string, error) { | ||
| return configMapResource.GetConfigHash(ctx) | ||
| } |
There was a problem hiding this comment.
Why Getter does not takes context as an input? Couldn't we pass configMapResource.GetConfigHash to statefulset resource?
0x5d
previously approved these changes
Dec 20, 2021
alenkacz
force-pushed
the
av/configmap-hash-restart
branch
from
0c5eaf6
to
176f826
Compare
alenkacz
force-pushed
the
av/configmap-hash-restart
branch
from
176f826
to
6e555d5
Compare
0x5d
approved these changes
Dec 20, 2021
Merged
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
After a user changes config in Cluster CR, the configmap is updated but we don't trigger restart of the redpanda pods so the new configuration does not get loaded until the pods are not restarted for some other reason. This adds an immediate restart to all redpanda nodes after the configmap changes. We achieve that by adding annotation with configmap hash to redpanda pods.
Fixes #2619
[ch-6518]
Release notes
Improvements
k8s: After cluster config is changed in CR, the redpanda pods will get restarted for the config to get used.
Beware that updating to this version of operator will always trigger one restart of your managed redpanda clusters after it's updated.