Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redpanda/cluster: Improve logging for leader_balancer #3271

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

BenPope
Copy link
Member

@BenPope BenPope commented Dec 15, 2021

Cover letter

  • Reduce log level to debug for initiatiating transfer
  • Log info for successful transfer

Fixes #3269

Signed-off-by: Ben Pope ben@vectorized.io

Unrelated Failures:

npm ERR! code ETIMEDOUT
  | npm ERR! errno ETIMEDOUT
  | npm ERR! network request to https://registry.npmjs.org/rewire failed, reason: connect ETIMEDOUT 104.16.24.35:443

And:

npm WARN deprecated querystring@0.2.0: The querystring API is considered Legacy. new code should use the URLSearchParams API instead.
  | npm WARN deprecated chokidar@2.1.8: Chokidar 2 will break on node v14+. Upgrade to chokidar 3 with 15x less dependencies.
  | npm WARN deprecated fsevents@1.2.13: fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2.
  | npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
  | npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
  | npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@~2.3.2 (node_modules/chokidar/node_modules/fsevents):
  | npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.3.2: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
  | npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@^1.2.7 (node_modules/watchpack-chokidar2/node_modules/chokidar/node_modules/fsevents):
  | npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.13: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
  |  
  | npm ERR! Unexpected end of JSON input while parsing near '...a+rf8Dt9ndqiZOSaKIq7g'

And:

curl: (28) Failed to connect to github.com port 443: Connection timed out
  | curl: (35) OpenSSL SSL_connect: SSL_ERROR_SYSCALL in connection to github.com:443
  | task: Failed to run task "rp:run-ducktape-tests": task: Failed to run task "rp:init-ducktape-containers": task: Failed to run task "dev:install-docker-compose": exit status 35

Release notes

Improvements

  • redpanda/cluster: Improve logging for leader_balancer

@BenPope BenPope force-pushed the rebalancing-logging-improvements branch 2 times, most recently from 5f5c6f7 to 3265dda Compare December 15, 2021 14:47
@BenPope BenPope added the kind/enhance New feature or request label Dec 15, 2021
Comment on lines 301 to 307
vlog(
clusterlog.info,
"Transferred leadership for group {} from {} to {}",
transfer->group,
transfer->from,
transfer->to);

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is something like this already logged near the bottom of this routine?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Not sure how I missed that.

…ents

* Reduce log level to debug for No leadership balance improvements

Fixes redpanda-data#3269

Signed-off-by: Ben Pope <ben@vectorized.io>
@BenPope BenPope force-pushed the rebalancing-logging-improvements branch from 3265dda to 3bbd1c8 Compare December 15, 2021 19:37
@BenPope BenPope requested a review from dotnwat December 15, 2021 19:38
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/redpanda kind/enhance New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mute leadership transfer messages when no action is taken.
2 participants