Fix patching PDB resources #3303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alenkacz
commented
Dec 17, 2021
| // not be updated | ||
| updated, err := resources.Update(context.TODO(), actual, actual, c, ctrl.Log.WithName("test")) | ||
| assert.NoError(t, err) | ||
| assert.False(t, updated) |
There was a problem hiding this comment.
this test was failing before I bumped the objectmatcher lib and started ignoring the selector
alenkacz
force-pushed
the
av/pdb-patch
branch
from
46b3a72
to
2f93432
Compare
RafalKorepta
approved these changes
Dec 17, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
PDB was constantly trying to be patched because of the way how apimachinery libs internally work. This was fixed in newer version of the objectmatcher library so bumping it and ignoring the selector fixes the issue.
Fixes #3301
Release notes
Improvements
k8s: fixed a bug with attempting to patch PDB selector when not required