cloud_storage: fix logs about http client errors #3356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 23, 2021 18:15
The real error message should be printed in the code that calls the http client, it has the right context
This is a normal situation when http client disconnects, we will just retry.
Lazin
reviewed
Dec 23, 2021
| @@ -247,10 +247,10 @@ ss::future<> client::response_stream::shutdown() { return _client->stop(); } | |||
| /// Return failed future if ec is set, otherwise return future in ready state | |||
| static ss::future<iobuf> | |||
| fail_on_error(prefix_logger& ctxlog, const boost::beast::error_code& ec) { | |||
| if (!ec) { | |||
| if (!ec.failed()) { | |||
There was a problem hiding this comment.
nit: why this change is needed?
There was a problem hiding this comment.
not needed, but I think that's more readable
Lazin
approved these changes
Dec 23, 2021
jcsp
approved these changes
Dec 23, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
Downgrade log message severity in case of http client disconnect since it's a normal mode of operation.
Fixes: #3333
Release notes
Improvements