rpk: patch group seeking behavior #3404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I thought that an embedded private struct with public fields would mean the fields are public, but it does not, which meant that if seeking had per-partition errors, PrintStructFields would panic. We now use dedicated public fields.
This bumps kadm to a version that uses per-partition errors if OffsetCommitResponse is missing some topics/partitions in the response that were in the request. Notably, this was seen when seeking against redpanda: redpanda does not today either match the request ordering, or does not respond to everything all of the time. This is tracked in #3403.
This was referenced Feb 8, 2022
Closed
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observed in the wild: seeking sometimes errored even though a commit went through because the OffsetCommit response was not as expected, and an error while seeking panicked.
For the first issue, we relax the strictness on what we expect an OffsetCommit response to look like. For the latter, we just fix the panic.
Release notes
rpk group seekif there was an error during the offset commit