c/metadata_dissemination: fix applying updates from health #3487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This regressed in c8f4f12 Node health reports may disagree with one another about leadership in a particular term, if some of them claim that it's null (because they've seen the term in their own log after restart, but not yet received an append_entries from the leader). To avoid a rogue node health report resetting the leadership of a topic to null, ignore health report leadership information if it claims a null leader. Non-null claims are always believable, because of the term: if they're out of date, then they were still correct for the term they claim, and we ignore those out of date terms in partition_leaders_table::update_partition_leader. Fixes redpanda-data#3486
jcsp
changed the title
|
Debug build failure was #3384, retrying it |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
c/metadata_dissemination: fix applying updates from health
Node health reports may disagree with one another about
leadership in a particular term, if some of them claim
that it's null (because they've seen the term in their
own log after restart, but not yet received an append_entries
from the leader).
To avoid a rogue node health report resetting the leadership
of a topic to null, ignore health report leadership
information if it claims a null leader.
Non-null claims are always believable, because of the term:
if they're out of date, then they were still correct for
the term they claim, and we ignore those out of date
terms in partition_leaders_table::update_partition_leader.
Fixes #3486
Release notes
Improvements