rpc: Wrap ZSTD_error_memory_allocation to std::bad_alloc & catch exceptions from dispatch #3567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VadimPlh
force-pushed
the
zstd-alloc-error
branch
from
d6323af
to
6c4d86b
Compare
|
#3511 (review) is related |
jcsp
reviewed
Jan 21, 2022
jcsp
changed the title
|
Don't forget release notes in the description, even if it's just marking it as not having any like this: Release notes
|
VadimPlh
force-pushed
the
zstd-alloc-error
branch
2 times, most recently
from
3fb94d7
to
32c47bd
Compare
VadimPlh
force-pushed
the
zstd-alloc-error
branch
from
32c47bd
to
cac3b08
Compare
VadimPlh
force-pushed
the
zstd-alloc-error
branch
from
cac3b08
to
2ed895f
Compare
|
Retried debug build for "Failed to remove..." failure. |
VadimPlh
force-pushed
the
zstd-alloc-error
branch
2 times, most recently
from
76bcce6
to
97a44b8
Compare
VadimPlh
force-pushed
the
zstd-alloc-error
branch
from
97a44b8
to
97e1863
Compare
jcsp
approved these changes
Jan 24, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
Wrap ZSTD_error_memory_allocation to std::bad_alloc and catch it in rpc::simple_protocol
Release notes