Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: fix core count invariant check #3645

Merged
merged 2 commits into from
Jan 28, 2022

Conversation

jcsp
Copy link
Contributor

@jcsp jcsp commented Jan 28, 2022

Cover letter

Save the high water mark of core count, rather than
just the original first-startup value. This way we
refuse to decrease after increasing, rather than
only refusing to decrease relative to first startup.

Fixes: #3644

Release notes

Improvements

  • Checks for node CPU count decreases are more robust, to guard against partition unavailability resulting from incorrectly decreasing the CPU count of an existing redpanda node.

Save the high water mark of core count, rather than
just the original first-startup value.  This way we
refuse to decrease after increasing, rather than
only refusing to decrease relative to first startup.

Fixes: redpanda-data#3644
This exercises how redpanda behaves when the CPU count
of a node changes.
@jcsp jcsp merged commit 1423707 into redpanda-data:dev Jan 28, 2022
@jcsp jcsp deleted the issue-3644-config-invariants branch January 28, 2022 16:23
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

controller/members_manager: config_invariants doesn't always prevent decreasing core count
2 participants