Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schema_registry/proto: Accept protobuf as an encoded file descriptor #3663

Merged
merged 5 commits into from
Feb 2, 2022
Merged

schema_registry/proto: Accept protobuf as an encoded file descriptor #3663

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
90d60f7
schema_registry/proto: Log.warn for failed decode
BenPope Jan 28, 2022
a3df94f
schema_registry/proto: Don' use moved from value in error message
BenPope Jan 28, 2022
d74b9e5
schema_registry/proto: Support encoded proto
BenPope Jan 28, 2022
3705cb7
ducktape: Introduce SerdeClient
BenPope Jan 31, 2022
dae8b89
schema_registry/test: Test avro and proto serializer compatibility
BenPope Jan 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/v/pandaproxy/schema_registry/protobuf.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ ss::future<const pb::FileDescriptor*> build_file_with_refs(
ss::future<const pb::FileDescriptor*> import_schema(
pb::DescriptorPool& dp, sharded_store& store, canonical_schema schema) {
try {
co_return co_await build_file_with_refs(dp, store, std::move(schema));
co_return co_await build_file_with_refs(dp, store, schema);
} catch (const exception& e) {
vlog(plog.warn, "Failed to decode schema: {}", e.what());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch!

throw as_exception(invalid_schema(schema));
Expand Down