Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix consumer group recovery #3732

Merged

Conversation

mmaslankaprv
Copy link
Member

@mmaslankaprv mmaslankaprv commented Feb 4, 2022

Cover letter

Using persisted group metadata to recover group state when group coordinator changes.

Release notes

Signed-off-by: Michal Maslanka <michal@vectorized.io>
Signed-off-by: Michal Maslanka <michal@vectorized.io>
@mmaslankaprv mmaslankaprv marked this pull request as draft February 4, 2022 14:03
@mmaslankaprv mmaslankaprv marked this pull request as ready for review February 4, 2022 16:05
Copy link
Member

@dotnwat dotnwat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome find

@emaxerrno
Copy link
Contributor

does this need backporting?

@dotnwat
Copy link
Member

dotnwat commented Feb 8, 2022

I wonder if we have a metric or a signal we could use to write a ducktape test for this scenario?

@mmaslankaprv
Copy link
Member Author

I wonder if we have a metric or a signal we could use to write a ducktape test for this scenario?

We may try to count number of consumer rebalances during leadership transfers

@mmaslankaprv
Copy link
Member Author

I will merge this for now, and try to prepare a follow up PR

@mmaslankaprv mmaslankaprv merged commit 7a64fb1 into redpanda-data:dev Feb 8, 2022
ivotron added a commit that referenced this pull request Feb 9, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants