kafka: expire pending group members #3761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emaxerrno
reviewed
Feb 8, 2022
| if (g._partition) { | ||
| return fmt::format("{}", g._partition->ntp()); | ||
| } else { | ||
| return std::string("<none>"); |
There was a problem hiding this comment.
constexpr string_view? for these static strings?
There was a problem hiding this comment.
I wish but I dunno how the types would be compatible
emaxerrno
reviewed
Feb 8, 2022
emaxerrno
reviewed
Feb 8, 2022
emaxerrno
reviewed
Feb 8, 2022
|
good find! |
|
sorry! i meant to hit 'comment' |
dotnwat
force-pushed
the
group-expire-pending-members
branch
from
99a59dd
to
912f89d
Compare
mmaslankaprv
reviewed
Feb 9, 2022
Prior to this change a pending member that never rejoins might leave a pending member indefinitely. Now we kick em out. When pending members stick around it may cause issues when trying to determine of all members have joined. The function all members joined will return false if any pending member exists, which would occur if a pending member were left lingering in the group and this in turn may prevent the group from properly transitioning through the state machine. For example, the inline join completion that occurs in handle_join_group as well as in the complete_join callback all have scenarios gated on this condition which would prevent the group from moving into the sync phase. Signed-off-by: Noah Watkins <noah@redpanda.com>
On join we dump out a lot of metadata about the group and members at trace level. This is to aid in debugging stuck groups if they occur again. Signed-off-by: Noah Watkins <noah@redpanda.com>
dotnwat
force-pushed
the
group-expire-pending-members
branch
from
912f89d
to
a41cb00
Compare
|
@mmaslankaprv force pushed ⬆️ to fix use-after-free bug that was causing the CI failure. |
|
ping @mmaslankaprv |
mmaslankaprv
approved these changes
Feb 14, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
Prior to this change a pending member that never rejoins might leave a
pending member indefinitely. Now we kick em out.
When pending members stick around it may cause issues when trying to
determine of all members have joined. The function all members joined
will return false if any pending member exists, which would occur if a
pending member were left lingering in the group and this in turn may
prevent the group from properly transitioning through the state machine.
For example, the inline join completion that occurs in handle_join_group
as well as in the complete_join callback all have scenarios gated on
this condition which would prevent the group from moving into the sync
phase.
Release notes