cloud_storage: fix race between remote_partition::stop and readers #3813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
Fixes redpanda-data#3507. Previously remote_partition readers could return segment readers to the partition object after stop() was called, leading to an assertion failure in the remote_partition destructor. To fix that we make readers hold a guard for the partition gate and do a last pass over the eviction list after the gate was closed (and thus all readers finished). Test test_remote_partition_lifetime_issue is removed because it tries to model the situation (readers trying to read after remote_partition::stop()) which is now impossible.
We don't need abort_source because readers can use _gate.is_closed() to check if they need to proceed, and eviction loop can use the broken_condition_variable exception as a stop condition.
|
build error is #3714, restarted |
Lazin
approved these changes
Feb 17, 2022
ztlpn
added a commit
that referenced
this pull request
Feb 19, 2022
Backport #3813: cloud_storage: fix race between remote_partition::stop and readers
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
Fixes #3507. Previously remote_partition readers could return segment readers to the partition object after stop() was called, leading to an assertion failure in the remote_partition destructor. To fix that we make readers hold a guard for the partition gate and do a last pass over the eviction list after the gate was closed (and thus all readers had finished).
Release notes
Bug fixes